From cf287f31ab450b19b9fe14e2f1abd50f3b8f2303 Mon Sep 17 00:00:00 2001 From: Marco Crapts Date: Thu, 8 Jun 2023 22:22:29 +0200 Subject: [PATCH] fixes --- capacitor.config.ts | 2 +- src/components/Auth.vue | 56 ++++++++++++++--------------- src/components/Note/NoteEditor.vue | 5 ++- src/components/Note/NoteToolbar.vue | 3 +- src/components/TopBar/Settings.vue | 8 +---- src/components/ViewModes/Note.vue | 1 - src/components/ui/UIModal.vue | 7 ++-- src/composables/useFirebase.ts | 1 + src/composables/useHaptics.ts | 3 ++ src/composables/useNotes.ts | 4 +-- 10 files changed, 41 insertions(+), 49 deletions(-) create mode 100644 src/composables/useHaptics.ts diff --git a/capacitor.config.ts b/capacitor.config.ts index daaaac5..8862b73 100644 --- a/capacitor.config.ts +++ b/capacitor.config.ts @@ -16,7 +16,7 @@ const config: CapacitorConfig = { }, FirebaseAuthentication: { skipNativeAuth: false, - providers: ['google.com'] + providers: ['google.com', 'microsoft.com', 'github.com'] } } } diff --git a/src/components/Auth.vue b/src/components/Auth.vue index 9d20102..fd90cf4 100644 --- a/src/components/Auth.vue +++ b/src/components/Auth.vue @@ -60,37 +60,33 @@ const providers: Provider[] = [ const credential = GoogleAuthProvider.credential(result.credential?.idToken) await signInWithCredential(auth, credential) } - }, - { - name: 'microsoft', - icon: 'fa-brands fa-microsoft', - signin: async () => { - const result = await FirebaseAuthentication.signInWithMicrosoft({ - mode: 'redirect' - }) - const provider = new OAuthProvider('microsoft.com') - const credential = provider.credential({ - idToken: result.credential?.idToken, - rawNonce: result.credential?.nonce - }) - await signInWithCredential(auth, credential) - } - }, - { - name: 'github', - icon: 'fa-brands fa-github', - signin: async () => { - const result = await FirebaseAuthentication.signInWithGithub({ - mode: 'redirect' - }) - const provider = new OAuthProvider('github.com') - const credential = provider.credential({ - idToken: result.credential?.idToken, - rawNonce: result.credential?.nonce - }) - await signInWithCredential(auth, credential) - } } + // { + // name: 'microsoft', + // icon: 'fa-brands fa-microsoft', + // signin: async () => { + // const result = await FirebaseAuthentication.signInWithMicrosoft({ + // mode: 'redirect' + // }) + // const provider = new OAuthProvider('microsoft.com') + // // const credential = provider.credential({ + // // idToken: result.credential?.idToken, + // // rawNonce: result.credential?.nonce + // // }) + // if (result.credential) { + // const credential = provider.credential(result.credential) + // console.log(credential) + // try { + // const user = await signInWithCredential(auth, credential) + // console.log('user', user) + // } catch (error: any) { + // console.log(error) + // console.log('message', error.message) + // } + // } + // } + // } + // Microsoft users can't be signed in manually so this does not work on native ] // type Provider = (typeof providers)[number] const signInWithProvider = async (provider: Provider) => { diff --git a/src/components/Note/NoteEditor.vue b/src/components/Note/NoteEditor.vue index c030810..4b9e708 100644 --- a/src/components/Note/NoteEditor.vue +++ b/src/components/Note/NoteEditor.vue @@ -15,8 +15,7 @@ import ContextedPlugin from '@/ckeditor/ContextedPlugin' import { mdToHtml, htmlToMd } from '@/utils/markdown' import { getNoteByTitle, setActiveNote, addNote } from '@/composables/useNotes' import Autocomplete from '@/components/Note/Autocomplete.vue' -import { Haptics, ImpactStyle } from '@capacitor/haptics' - +import { vibrate } from '@/composables/useHaptics' const props = defineProps<{ note: Note }>() const emit = defineEmits<{ @@ -68,7 +67,7 @@ const handleClick = async ({ data }: { data: any }) => { let note: BaseNote | Note | undefined = getNoteByTitle(noteTitle) if (!note) note = addNote(noteTitle, '') setActiveNote(note.id) - await Haptics.impact({ style: ImpactStyle.Light }) + await vibrate() } const autocompleteRef = ref | null>(null) diff --git a/src/components/Note/NoteToolbar.vue b/src/components/Note/NoteToolbar.vue index 4e7f8a1..8baa73c 100644 --- a/src/components/Note/NoteToolbar.vue +++ b/src/components/Note/NoteToolbar.vue @@ -2,6 +2,7 @@ import { Capacitor } from '@capacitor/core' import { Dialog } from '@capacitor/dialog' import type { ConfirmOptions } from '@capacitor/dialog' +import { vibrate } from '@/composables/useHaptics' const props = defineProps<{ note: Note @@ -57,7 +58,7 @@ const openModal = async (open: () => void, modal: ModalOptions) => { diff --git a/src/components/TopBar/Settings.vue b/src/components/TopBar/Settings.vue index 3080055..dbd484a 100644 --- a/src/components/TopBar/Settings.vue +++ b/src/components/TopBar/Settings.vue @@ -1,12 +1,6 @@